JarlFrank
I like Thief THIS much
Good crafting:
socketing items in Diablo 2.
broken unique items in Baldur's Gate 2 that have to be re-forged (Flail of Ages)
Making powerful items from very rare and hard to obtain ingredients (like dragon skin armor or demon tooth axes or whatever)
Bad crafting:
collect 10 plants to make a healing potion
mine ore so you can forge a standard non-enchanted sword that is identical to the swords you can get for 50 gold at the next vendor's
forge powerful items from common ingredients
I'd argue the crafting you're describing is not crafting, it's really sidequests - town wizard says "bring me King Rat penis and Qeen Dragoness pussy and imma make you a sword squirting acid", that's not crafting.
And the thing with plants is alchemy and I quite like that, if well implemented (Gothic, Risen 1, Witcher 1). You can either buy potions (at non-trivial prices) or invest points in alchemy and craft them (plus better versions, plus shit you can't buy). That's good.
Which basically proves that crafting is only good when it's not really crafting