Polls need next-gen

[Jigawatt]

Refreshing the page to vote in/view results of polls is turning prestigious RPGCodex into the laughing stock of the internet. I demand some javascript for viewing results, and AJAX for voting. Chop chop

 

[DarkUnderlord]

No.

 

[King Crispy]

 

[Jaesun]

That was an excellent summary Crispy. Thank you.

 

[Xor]

It needs the "stare" music from Kill Bill.

 

[Jaesun]

It needs the "stare" music from Kill Bill.

I like you Xor. NOHOMO.

 

[gromit]

Multiple-axis polling.

 

[MicoSelva]

It needs the "stare" music from Kill Bill.

 

[Orgasm]

DIY

same old same old

 

[Melcar]

Bullshit.

 

[Jigawatt]

DIY

I might if I get bored in the next week or so. Would you accept a code patch if I whipped this up DU?

 

[DarkUnderlord]

I doubt your abilities.

 

[DraQ]

Multiple-axis polling.

 

[Jaesun]

My first movie

DarkUnderlord vs Jigawatt the epic battle

 

[Jigawatt]

I doubt your abilities.

Challenge accepted!

 

[Jigawatt]

Alright, here's the patch

In the file viewtopic_poll_ballot.tpl
(I worked off the codex copy of this file)

Line 1:
//Add
<script type="text/javascript">
	function viewResult() {
		document.getElementById("pollresultsjs").style.display = "table-row-group";
		document.getElementById("pollballotjs").style.display = "none";
	}
</script>
<tbody id="pollballotjs">

Lines 10-11:
//Replace
<td><input type="radio" name="vote_id" value="{poll_option.POLL_OPTION_ID}" />&nbsp;</td>
<td><span class="gen">{poll_option.POLL_OPTION_CAPTION}</span></td>
//With
<td><input type="radio" name="vote_id" value="{poll_optionb.POLL_OPTION_ID}" />&nbsp;</td>
<td><span class="gen">{poll_optionb.POLL_OPTION_CAPTION}</span></td>
//Only change is poll_option classname changed to poll_optionb

Line 23:
//Replace the segment
<a href="{U_VIEW_RESULTS}" class="gensmall">{L_VIEW_RESULTS}</a>
//With
<a href="{U_VIEW_RESULTS}" class="gensmall" onclick="viewResult(); return false;" </a>

End of file:
//Add
</tbody>

<tbody id="pollresultsjs" style="display:none;">
	{POLL_JS}
</tbody>

In viewtopic.php
(Didn't have codex copy for this, obviously)
Assume that the line for the comment 'Does this topic contain a poll?' is 677

Line 724
//Comment out the if statement and open bracket 
if ( $user_voted || ...

Line 770
//Comment out the close bracket for the if statement

Line 771
//Replace
else
//With
if (!( $user_voted || $view_result || $poll_expired || !$is_auth['auth_vote'] || $forum_topic_data['topic_status'] == TOPIC_LOCKED ))
//ie the inverse of the commented out if statement above

Line 775-776
//Add
'polljs' => 'viewtopic_poll_result.tpl'
//to the array

Line 786
//Replace
"poll_option"
//With
"poll_optionb"

Line 801 (before the if close bracket)
//Add
$template->assign_var_from_handle('POLL_JS', 'polljs');

That will create a nice little javascript based switch to see the results of a poll. People without javascript will see no change to the existing functionality. There's probably a way to expand on this to provide AJAX voting but because of the weird way phpBB constructs pages I don't think there's an easy way to recalculate the graph after voting.

Happy new year, motherfucker

 

[Truman]

Nice stuff, if it works

 

[DarkUnderlord]

It worked. Just had to correct the view results link.

 

[Jigawatt]

Cool, just got to see it in action. It would be more useful to have ajax for the voting because that's where the most annoying page reload is. From having a quick look there isn't going to be an easy way to get it going because the graph would have to be rebuilt and the template engine doesn't seem to be set up for it. Shame really.